Code Simplicity Metrics: ahma

Overall Repository Simplicity: 55%

Generated on: 2026-03-23 13:30:24

Executive Summary

The repository requires significant architectural review. Multiple areas show high complexity.

Rust Simplicity (Avg: 55%)

By Crate

1. ahma_llm_monitor: 63%
2. ahma_http_mcp_client: 61%
3. ahma_simplify: 56%
4. ahma_mcp: 55%
5. ahma_http_bridge: 52%
6. ahma_common: 48%

Top 20 Rust Code Complexity Issues (Lowest Simplicity)

1. common/server.rs: Simplicity: 36% (High Cognitive Complexity)** ahma_http_bridge/tests/common/server.rs
   • Metrics: Cog: 24, Cyc: 85, SLOC: 481, MI: 0.9
   • Hotspots:
     • wait_for_startup_info() lines 337-367: Cog=6, Cyc=9, SLOC=31
     • resolve_binary_path() lines 107-162: Cog=5, Cyc=14, SLOC=56
     • wait_for_health() lines 369-388: Cog=3, Cyc=4, SLOC=20
     • wire_output_reader() lines 235-242: Cog=2, Cyc=3, SLOC=8
     • configure_server_command() lines 282-305: Cog=2, Cyc=3, SLOC=24
2. linux_sandbox_integration_test.rs: Simplicity: 37% (High Cyclomatic Complexity)** ahma_mcp/tests/linux_sandbox_integration_test.rs
   • Metrics: Cog: 15, Cyc: 75, SLOC: 544, MI: 1.0
   • Hotspots:
     • add_system_read_rules() lines 164-174: Cog=3, Cyc=4, SLOC=11
     • detect_landlock_enforcement() lines 33-41: Cog=2, Cyc=3, SLOC=9
     • kernel_version_supports_landlock() lines 82-86: Cog=2, Cyc=4, SLOC=5
     • print_landlock_diagnostics() lines 456-466: Cog=2, Cyc=3, SLOC=11
     • test_landlock_availability_check() lines 470-478: Cog=2, Cyc=2, SLOC=9
3. models.rs: Simplicity: 37% (High Cognitive Complexity)** ahma_simplify/src/models.rs
   • Metrics: Cog: 21, Cyc: 71, SLOC: 560, MI: 1.3
   • Hotspots:
     • weighted_function_mi() lines 276-291: Cog=5, Cyc=5, SLOC=16
     • calculate() lines 210-238: Cog=3, Cyc=4, SLOC=29
     • resolve_mi() lines 246-252: Cog=3, Cyc=3, SLOC=7
     • extract_from_spaces() lines 82-96: Cog=2, Cyc=4, SLOC=15
     • is_nontrivial_function() lines 109-112: Cog=2, Cyc=3, SLOC=4
4. callback_system.rs: Simplicity: 38% (High Cyclomatic Complexity)** ahma_mcp/src/callback_system.rs
   • Metrics: Cog: 11, Cyc: 74, SLOC: 560, MI: 1.4
   • Hotspots:
     • format_output() lines 188-191: Cog=2, Cyc=2, SLOC=4
     • format_final_result() lines 201-204: Cog=2, Cyc=2, SLOC=4
     • as_message() lines 53-61: Cog=1, Cyc=6, SLOC=9
     • detect_cancellation_kind() lines 64-86: Cog=1, Cyc=4, SLOC=23
     • format_log_alert() lines 206-217: Cog=1, Cyc=3, SLOC=12
5. client_coverage_expansion_test.rs: Simplicity: 38% (High Cyclomatic Complexity)** ahma_mcp/tests/client_coverage_expansion_test.rs
   • Metrics: Cog: 4, Cyc: 80, SLOC: 432, MI: 3.5
   • Hotspots:
     • test_sandboxed_shell_with_working_dir() lines 303-336: Cog=2, Cyc=5, SLOC=34
     • call_test_tool() lines 21-32: Cog=1, Cyc=3, SLOC=12
     • test_async_operation_lifecycle() lines 209-240: Cog=1, Cyc=6, SLOC=32
     • get_result_text() lines 34-41: Cog=0, Cyc=3, SLOC=8
     • test_client_start_process_with_tools_dir() lines 54-73: Cog=0, Cyc=7, SLOC=20
6. core.rs: Simplicity: 38% (High Cognitive Complexity)** ahma_mcp/src/sandbox/core.rs
   • Metrics: Cog: 27, Cyc: 74, SLOC: 323, MI: 7.9
   • Hotspots:
     • resolve_livelog_scopes() lines 13-21: Cog=3, Cyc=3, SLOC=9
     • resolve_log_dir_symlinks() lines 27-42: Cog=3, Cyc=4, SLOC=16
     • new() lines 136-163: Cog=3, Cyc=4, SLOC=28
     • validate_path() lines 226-245: Cog=3, Cyc=5, SLOC=20
     • check_security_policies() lines 281-295: Cog=3, Cyc=4, SLOC=15
7. client.rs: Simplicity: 39% (High Cognitive Complexity)** ahma_mcp/src/test_utils/client.rs
   • Metrics: Cog: 42, Cyc: 56, SLOC: 424, MI: 6.6
   • Hotspots:
     • run_command() lines 195-247: Cog=22, Cyc=12, SLOC=53
     • get_test_binary_path() lines 28-70: Cog=14, Cyc=8, SLOC=43
     • tools_dir() lines 99-110: Cog=2, Cyc=2, SLOC=12
     • build() lines 156-193: Cog=2, Cyc=5, SLOC=38
     • use_prebuilt_binary() lines 72-75: Cog=1, Cyc=2, SLOC=4
8. test_utils_coverage_test.rs: Simplicity: 39% (High Cyclomatic Complexity)** ahma_mcp/tests/test_utils_coverage_test.rs
   • Metrics: Cog: 4, Cyc: 57, SLOC: 555, MI: 2.6
   • Hotspots:
     • test_get_binary_path_with_absolute_cargo_target_dir() lines 470-500: Cog=2, Cyc=2, SLOC=31
     • test_get_binary_path_with_relative_cargo_target_dir() lines 503-532: Cog=2, Cyc=3, SLOC=30
     • test_get_binary_path_default_target_dir() lines 448-467: Cog=0, Cyc=2, SLOC=20
     • test_test_command_includes_no_sandbox() lines 548-555: Cog=0, Cyc=2, SLOC=8
9. sequence_failure_edge_cases_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/sequence_failure_edge_cases_test.rs
   • Metrics: Cog: 8, Cyc: 65, SLOC: 528, MI: 4.1
   • Hotspots:
     • test_sequence_step_failure_stops_subsequent_steps() lines 175-234: Cog=3, Cyc=11, SLOC=60
     • test_sequence_with_missing_subcommand_reference() lines 242-291: Cog=2, Cyc=12, SLOC=50
     • test_sequence_failure_with_filesystem_markers() lines 300-398: Cog=2, Cyc=11, SLOC=99
     • test_empty_sequence_handling() lines 406-449: Cog=1, Cyc=10, SLOC=44
     • setup_failure_test_configs() lines 21-166: Cog=0, Cyc=8, SLOC=146
10. cli_extended_integration_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/cli_extended_integration_test.rs
    • Metrics: Cog: 15, Cyc: 48, SLOC: 638, MI: 2.9
    • Hotspots:
      • test_validate_specific_files() lines 553-574: Cog=6, Cyc=5, SLOC=22
      • test_generate_schema_valid_json_schema() lines 612-637: Cog=3, Cyc=4, SLOC=26
      • test_ahma_mcp_custom_tools_dir() lines 98-160: Cog=2, Cyc=3, SLOC=63
      • test_ahma_mcp_cli_simple_tool() lines 435-461: Cog=2, Cyc=3, SLOC=27
      • test_ahma_mcp_multiple_flags() lines 188-220: Cog=1, Cyc=5, SLOC=33
11. mcp_service_coverage_improvement_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/mcp_service_coverage_improvement_test.rs
    • Metrics: Cog: 0, Cyc: 34, SLOC: 821, MI: 1.0
    • Hotspots:
      • test_schema_generation_normalizes_option_types() lines 13-103: Cog=0, Cyc=2, SLOC=91
      • test_schema_generation_array_with_items() lines 107-184: Cog=0, Cyc=2, SLOC=78
      • test_schema_generation_positional_args() lines 188-294: Cog=0, Cyc=4, SLOC=107
      • test_schema_generation_multiple_subcommands() lines 298-399: Cog=0, Cyc=5, SLOC=102
      • test_schema_generation_nested_subcommands() lines 403-493: Cog=0, Cyc=3, SLOC=91
12. async_comprehensive.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/shell_pool/async_comprehensive.rs
    • Metrics: Cog: 1, Cyc: 60, SLOC: 501, MI: 3.7
    • Hotspots:
      • make_workdir() lines 32-42: Cog=1, Cyc=5, SLOC=11
      • test_basic_shell_command_execution() lines 46-74: Cog=0, Cyc=4, SLOC=29
      • test_working_directory_handling() lines 78-111: Cog=0, Cyc=5, SLOC=34
      • test_complex_shell_commands() lines 115-143: Cog=0, Cyc=4, SLOC=29
      • test_invalid_command_handling() lines 147-176: Cog=0, Cyc=4, SLOC=30
13. cli_binary_integration_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/cli_binary_integration_test.rs
    • Metrics: Cog: 9, Cyc: 50, SLOC: 621, MI: 2.9
    • Hotspots:
      • test_ahma_mcp_cli_mode_echo_tool() lines 122-162: Cog=2, Cyc=9, SLOC=41
      • test_ahma_mcp_list_tools_with_stdio_server() lines 491-529: Cog=2, Cyc=4, SLOC=39
      • test_ahma_mcp_list_tools_json_format() lines 532-564: Cog=2, Cyc=4, SLOC=33
      • test_ahma_mcp_stdio_mode_rejects_tty() lines 165-191: Cog=1, Cyc=4, SLOC=27
      • test_validate_single_valid_file() lines 302-324: Cog=1, Cyc=2, SLOC=23
14. arg_processor.rs: Simplicity: 40% (High Cognitive Complexity)** ahma_mcp/src/adapter/preparer/arg_processor.rs
    • Metrics: Cog: 44, Cyc: 57, SLOC: 221, MI: 15.0
    • Hotspots:
      • emit_file_arg_if_configured() lines 63-92: Cog=8, Cyc=8, SLOC=30
      • process_option_args() lines 161-188: Cog=8, Cyc=7, SLOC=28
      • emit_boolean_flag_if_true() lines 94-119: Cog=6, Cyc=8, SLOC=26
      • process_explicit_args() lines 190-201: Cog=6, Cyc=6, SLOC=12
      • process_all() lines 203-220: Cog=5, Cyc=8, SLOC=18
15. modes/server.rs: Simplicity: 40% (High Cognitive Complexity)** ahma_mcp/src/shell/modes/server.rs
    • Metrics: Cog: 60, Cyc: 46, SLOC: 431, MI: 8.1
    • Hotspots:
      • run_server_mode() lines 35-431: Cog=60, Cyc=45, SLOC=397
16. tool_availability_coverage_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/tool_availability_coverage_test.rs
    • Metrics: Cog: 6, Cyc: 43, SLOC: 631, MI: 2.7
    • Hotspots:
      • test_evaluate_subcommand_disabled_when_probe_fails() lines 376-433: Cog=2, Cyc=5, SLOC=58
      • test_evaluate_nested_subcommands() lines 475-534: Cog=2, Cyc=5, SLOC=60
      • test_evaluate_custom_success_exit_codes() lines 537-569: Cog=2, Cyc=3, SLOC=33
      • build_subcommand() lines 27-49: Cog=0, Cyc=2, SLOC=23
      • test_format_install_guidance_whitespace_only_instructions() lines 200-221: Cog=0, Cyc=2, SLOC=22
17. mcp_callback_comprehensive_test.rs: Simplicity: 40% (High Cyclomatic Complexity)** ahma_mcp/tests/mcp_callback_comprehensive_test.rs
    • Metrics: Cog: 14, Cyc: 54, SLOC: 511, MI: 4.9
    • Hotspots:
      • send_progress() lines 51-64: Cog=2, Cyc=3, SLOC=14
      • test_progress_update_started() lines 74-100: Cog=1, Cyc=3, SLOC=27
      • test_progress_update_with_percentage() lines 105-131: Cog=1, Cyc=3, SLOC=27
      • test_progress_update_without_percentage() lines 134-153: Cog=1, Cyc=3, SLOC=20
      • test_progress_update_stdout_output() lines 158-179: Cog=1, Cyc=3, SLOC=22
18. handshake_concurrency_test.rs: Simplicity: 40% (High Cognitive Complexity)** ahma_http_bridge/tests/handshake_concurrency_test.rs
    • Metrics: Cog: 33, Cyc: 42, SLOC: 538, MI: 5.2
    • Hotspots:
      • test_slow_client_handshake() lines 291-457: Cog=23, Cyc=12, SLOC=167
      • start_deferred_sandbox_server() lines 55-101: Cog=3, Cyc=4, SLOC=47
      • send_mcp_request_raw() lines 147-179: Cog=3, Cyc=6, SLOC=33
      • send_mcp_request() lines 103-145: Cog=2, Cyc=9, SLOC=43
      • test_tool_call_before_roots_handshake() lines 188-282: Cog=1, Cyc=4, SLOC=95
19. config_watcher.rs: Simplicity: 40% (High Cognitive Complexity)** ahma_mcp/src/mcp_service/config_watcher.rs
    • Metrics: Cog: 66, Cyc: 43, SLOC: 286, MI: 13.4
    • Hotspots:
      • configure_sandbox_from_roots() lines 122-285: Cog=48, Cyc=21, SLOC=164
      • start_config_watcher() lines 41-116: Cog=13, Cyc=17, SLOC=76
      • update_tools() lines 16-38: Cog=5, Cyc=3, SLOC=23
20. cargo_tool_integration_test.rs: Simplicity: 41% (High Cognitive Complexity)** ahma_http_bridge/tests/cargo_tool_integration_test.rs
    • Metrics: Cog: 23, Cyc: 46, SLOC: 619, MI: 4.7
    • Hotspots:
      • test_sandboxed_shell_execution_with_assertions() lines 488-619: Cog=5, Cyc=7, SLOC=132
      • setup_cargo_test() lines 115-152: Cog=3, Cyc=5, SLOC=38
      • test_cargo_check_with_assertions() lines 159-204: Cog=2, Cyc=5, SLOC=46
      • test_cargo_clippy_basic_with_assertions() lines 211-248: Cog=2, Cyc=2, SLOC=38
      • test_cargo_clippy_with_tests_flag_assertions() lines 255-305: Cog=2, Cyc=6, SLOC=51

Metrics Glossary

Cognitive Complexity

• Description: Measures how hard it is to understand the control flow of the code. See
• How to Improve: Extract complex conditions into well-named functions and reduce nesting levels.

Cyclomatic Complexity

• Description: Measures the number of linearly independent paths through the source code. See
• How to Improve: Use polymorphic abstractions instead of complex switch/if-else chains, and break down large functions into smaller components.

Source Lines of Code (SLOC)

• Description: A measure of the size of the computer program by counting the number of lines in the text of the source code. See
• How to Improve: Remove dead code and refactor repetitive logic into reusable helper functions or macros.

Maintainability Index (MI)

• Description: A composite metric representing the relative ease of maintaining the code; higher is better. See
• How to Improve: Simultaneously reduce complexity (both cognitive and cyclomatic) and file size to boost the index.